Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show in embedded editor field config option #2165

Open
wants to merge 6 commits into
base: authoring-react-planning
Choose a base branch
from
Open

Show in embedded editor field config option #2165

wants to merge 6 commits into from

Conversation

thecalcc
Copy link
Contributor

@thecalcc thecalcc commented Dec 18, 2024 •
edited
Loading

STT-76

Front-end checklist

  • This pull request is adding missing TypeScript types to modified code segments where it's easy to do so with confidence
  • This pull request is using TypeScript interfaces instead of prop-types and updates usages where it's quick to do so
  • This pull request is using memo or PureComponent to define new React components (and updates existing usages in modified code segments)
  • This pull request is replacing lodash.get with optional chaining and nullish coalescing for modified code segments
  • This pull request is not importing anything from client-core directly (use superdeskApi)
  • This pull request is importing UI components from superdesk-ui-framework and superdeskApi when possible instead of using ones defined in this repository.
  • This pull request is not using planningApi where it is possible to use superdeskApi
  • This pull request is not adding redux based modals
  • In this pull request, properties of redux state are not being passed as props to components; instead, we connect it to the component that needs them. Except components where using a react key is required - do not connect those due to performance reasons.
  • This pull request is not adding redux actions that do not modify state (e.g. only calling angular services; those should be moved to planningApi)

@thecalcc
Copy link
Contributor Author

thecalcc commented Dec 18, 2024 •
edited
Loading

  • TODO: Make this field config option readOnly={true} & toggled on if required config option is set to true

Note: Since we haven't yet worked on the embedded event editor the condition: For each field in the Event form and Planning item form manager there will be a checkboc “Show in embedded form” next to the checkbox “Required“ has to be implemented there as well once we have started working on that

tomaskikutis
tomaskikutis reviewed Dec 19, 2024
View reviewed changes
client/components/planning-editor-standalone/profile-fields.ts Outdated
* If a field does not have show_in_embedded_editor or required toggled on
* we must not show it in the embedded editor
*/
if (!(fieldSchema.show_in_embedded_editor || fieldSchema.required)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll eventually use getPlanningProfileFields for non-embedded editors too. Add a argument which would tell if you want to get fields for embedded editor or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomaskikutis tomaskikutis tomaskikutis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thecalcc @tomaskikutis